Variables as toppings #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
approved these changes
Dec 9, 2024
|
Thanks @gacarrillor Yes, I didn't expected that you get the whole concept. It's the backend of the backend of the UsabILIty Topping thingy. We might can have a session about this part once. Anyway: Thanks for the code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass
path_variablesto theExportSettingswe resolve those. Means we take the variable as file path, get the file, create a topping file from it and write into the variable a resolved path (in Model Baker Topping Exporter this will result in an ilidata key).